Skip to content

Pushkit (VoIP) Support#99

Open
gus-bn wants to merge 4 commits into
ostinelli:masterfrom
thegurucompany:master
Open

Pushkit (VoIP) Support#99
gus-bn wants to merge 4 commits into
ostinelli:masterfrom
thegurucompany:master

Conversation

@gus-bn

@gus-bn gus-bn commented Oct 6, 2020

Copy link
Copy Markdown
  • In order to send pushkit notifications, apns-push-type must be sent as voip
  • Since this value is determined based on content_available for bg of alert values, the cleanest solution would be to allow overriding the request headers. This solution would also support: complication and fileprovider notifications.

Usage:

notification = Apnotic::Notification.new(push_token)
notification.custom_headers = {
  'apns-push-type' => 'voip',
  'apns-expiration' => 0
}
...

Sources:

@drale2k

drale2k commented Nov 20, 2020

Copy link
Copy Markdown

bump, needed very much

@scottharvey

Copy link
Copy Markdown

I also needed to send VoIP push notifications so I'm using the branch that @gustavobnmx created, it would be nice to have this merged into the main project. 👍

@benubois

benubois commented Sep 7, 2021

Copy link
Copy Markdown
Collaborator

Hi @gustavobnmx,

Thanks for making this! I like the symmetry with custom_payload. Having a way to merge in headers provides a valuable escape hatch to add anything without updates to apnotic.

Could the documentation be edited down to just demonstrate what is new around adding custom_headers? The new section feels redundant and the readme is already quite long.

After that would it be possible for you to squash your commits and force-push?

Finally, for voip specifically, what I'd like to see is a proper wrapper around the apns-push-type key, with an eye toward maintaining backward compatibility with background_notification?. However this does not need to hold up the merge of this pull request.

@bhishakBitcanny

Copy link
Copy Markdown

Is this going to be merged anytime soon? Would really help to solve sending VoIP push.

@ostinelli

Copy link
Copy Markdown
Owner

@bhishakBitcanny see @benubois previous remark, some work is pending for this to get merged. We welcome some help to close this if you're up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants