Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6737 Make index clear nav in Low Vision Default when no landmark is present #5083

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

sarken
Copy link
Collaborator

@sarken sarken commented Feb 27, 2025

Issue

https://otwarchive.atlassian.net/browse/AO3-6737

Purpose

If there's no landmark heading between the floated subnavigation and the index of blurbs, the blurbs get a bit squished off to the left. This lets them extend to the right.

Testing Instructions

  1. Log in
  2. Apply Low Vision Default skin
  3. Go to a work
  4. Bookmark the work

On the page you see after bookmarking the work, the blurb should no longer have a gap on the right the approximate width of the “My Bookmarks” button

@sarken sarken added Priority: High - Broken on Test Merge immediately after approval Awaiting Review labels Feb 27, 2025
Copy link
Member

@redsummernight redsummernight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the difference at smaller screen sizes (width around 650px or under).

@redsummernight redsummernight changed the title AO3-6737 Make index clear nav in Low Vision Default when no landmark present AO3-6737 Make index clear nav in Low Vision Default when no landmark is present Feb 27, 2025
@redsummernight redsummernight merged commit 716930c into otwcode:master Feb 27, 2025
29 checks passed
@sarken sarken deleted the AO3-6737 branch February 28, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants