fix: prioritize user-specified env vars #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, user-specified env vars are treated differently between the
metaflow-serviceandmetaflow-uiHelm charts.In the
metaflow-serviceHelm chart, user-specified env vars are placed after chart-specified env vars. In this case, K8s will treat them with priority based on order. However, in themetaflow-uiHelm chart, the chart-specified env vars are placed last, giving them priority. Besides being inconsistent, this is problematic as we want to set our own env vars that conflict with the chart-specified env vars (in this case,MF_METADATA_DB_USERandMF_METADATA_DB_PSWD).This commit switches the layout of the
metaflow-uienv vars to prioritize user-specified over chart-specified env vars.metaflow-servicelayout:metaflow-tools/charts/metaflow/charts/metaflow-service/templates/deployment.yaml
Lines 73 to 75 in d24572c
metaflow-uilayout:metaflow-tools/charts/metaflow/charts/metaflow-ui/templates/backend_deployment.yaml
Lines 51 to 75 in d24572c