feat: basic HTTP auth, configuration page and lots of refactoring - #20
Merged
Conversation
This prefix does not cause any issue but it's unnecessary.
This also allows us to handle missing plugins, i.e: /plugin/missingplugin.
This error was caused by a previous change in which we removed extra ID elements. This is now made simpler thanks to SCSS.
Contributor
Author
|
FYI @mlabeeb03. I'll try to finalize this tomorrow (Wednesday). |
Instead of storing a cookie for every plugin that requires launch, we create a single cookie with '+' separated value. We make use of the cookieStore native API (available everywhere since June 2025) to access cookie data. The variables are renamed to be more explicit. We now use class-based SCSS for styling, instead of manually setting style.display attribute.
This has almost no impact, outside of rewording some items.
regisb
force-pushed
the
regisb/http-basic-auth
branch
2 times, most recently
from
August 12, 2025 20:15
4baecfc to
522c952
Compare
mlabeeb03
reviewed
Aug 13, 2025
This is performed via two configuration settings. Note however that we don't yet support automatic reloading of credentials. This is unfortunate because there is no way to reload tutor Deck...
This panel displays all the main configuration item. Note however that there are still many TODO items, we should really clean them.
regisb
force-pushed
the
regisb/http-basic-auth
branch
from
August 13, 2025 15:26
522c952 to
55dfab1
Compare
regisb
force-pushed
the
regisb/http-basic-auth
branch
2 times, most recently
from
August 14, 2025 11:08
3335d51 to
6917c70
Compare
To achieve that, we had to get rid of the seq_command_executed request parameter. We replaced it by a cookie, which is cleared after the warning is displayed. Note that we had to remove a feature, which was to disable/enable all inputs while commands were running. This was causing very weird behaviour, where some disabled buttons were being re-enabled again. We also had to get rid of the cookieStore, which is not compatible with non-https access. Http access is required in the self-serve AMI, for instance.
regisb
force-pushed
the
regisb/http-basic-auth
branch
from
August 14, 2025 11:24
6917c70 to
898f5a2
Compare
regisb
marked this pull request as ready for review
August 14, 2025 14:03
github-project-automation
Bot
moved this from In Progress
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.