Enable Dynamic Schema Support for File Type Definitions in Analysis Types

[Azher2Ali]

1. Base Schema Updates:

   • fileType is now its own definition, allowing any string value.
   • file.fileType references this new definition, ensuring that it is always a required property for files.

2. Analysis Type Registration Schema:

   • If a user provides a file.fileType definition, it merges with the base schema definition.
   • Users can now add additional restrictions on file.fileType within the dynamic schema.

3. Data Structure Enhancements:

   • Added support for an optional options.fileTypes array in the analysisType dynamic schema, allowing users to define specific allowed file types.
   • Updated the controller and analysisTypeService.register to accept the options object.

4. Validation Enforcement:

   • The analysis submission/update process has been updated to enforce allowed fileTypes from the schema, in addition to JSON Schema validation.
   • If no file types are defined in the dynamic schema, all file types are accepted.

Notes:

• Additional validation logic has been implemented to ensure that the file types of each file submitted in an analysis match the allowed types defined in the dynamic schema, if provided.
• If no specific file types are defined for an analysis type, the check is skipped.

Impact:

This change provides a more flexible and dynamic way to handle file type validations for various analysis types, paving the way for future enhancements and custom analysis schemas.

[joneubank]

This looks complete, just two small nitpicks.

Can you add a comment to this PR that describes the behaviour when we are creating a new version of an existing schema - if you don't specify file types does it keep the existing file type restrictions or remove the existing restrictions? We can create another ticket to update this behaviour if it is unintuitive, I just want to record what the behaviour is.

[joneubank]

This looks like developer test logs, I think we can remove this or change it to debug level and add more details from the analysis schema that is being created.

[joneubank]

👍

[joneubank]

Looks like code formatting hasn't been run on this line, no space between comma and next argument.

[joneubank]

Looking good!