fix(account-creation): add asterisks and improve ux #19972
+47
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeBajeux
requested review from
JacquesLarique,
achrafHafedh and
sachinrameshn
and removed request for
a team
aottr
reviewed
Oct 24, 2025
| */ | ||
| // const { t: tCountry } = useTranslation(NAMESPACES.COUNTRY); | ||
| // const { t: tLanguage } = useTranslation(NAMESPACES.LANGUAGE); | ||
| const { t: tCountry } = useTranslation(NAMESPACES.COUNTRY); |
There was a problem hiding this comment.
I think in this case it would be better to use an alternative way of using useTranslation by passing an array of namespaces to the hook and then define the namespace in the t-function.
const { t } = useTranslation(['account-details', NAMESPACES.FORM, NAMESPACES.LANGUAGE, NAMESPACES.COUNTRY]);and then
tCountry(`country_${countryCode}`)becomes
t(`country_${countryCode}`, { ns: NAMESPACES.COUNTRY })There was a problem hiding this comment.
the first namespace (account-details) can be accessed without naming the ns.
So here it stays the same with t('asdf');
ref: https://react.i18next.com/latest/usetranslation-hook#usetranslation-params
ref: #MANAGER-19805 Signed-off-by: Maxime Bajeux <[email protected]>
MaximeBajeux
force-pushed
the
fix/MANAGER-19805
branch
from
d017b59 to
580687b
Compare
JacquesLarique
approved these changes
Oct 24, 2025
aottr
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-19805
Description
Ticket Reference: #MANAGER-19805
Additional Information