feat(pci-rancher): iam authentification #19975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
changed the title
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
3 times, most recently
from
3e29ce8 to
9239f80
Compare
ppprevost
requested review from
Tsiorifamonjena,
aTurmo,
fredericvilcot,
lionel95200x and
lolottetheclash
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
10 times, most recently
from
43483dc to
f2b845b
Compare
lolottetheclash
requested changes
Nov 5, 2025
Contributor
lolottetheclash
left a comment
lolottetheclash
left a comment
There was a problem hiding this comment.
just few things to check together if you want :)
packages/manager/apps/pci-rancher/src/data/hooks/useUpdateIamAuth/useUpdateIamAuth.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-rancher/src/pages/dashboard/iam-activation/iamActivationViewModel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-rancher/src/pages/dashboard/iam-activation/iamActivationViewModel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-rancher/src/pages/dashboard/iam-activation/iamActivation.page.tsx
Show resolved
Hide resolved
Tsiorifamonjena
previously approved these changes
Nov 5, 2025
aTurmo
reviewed
Nov 5, 2025
| }: { | ||
| projectId: string; | ||
| rancher: RancherService; | ||
| iamAuthEnabled: boolean; |
Contributor
There was a problem hiding this comment.
Question: I don't see this variable used, why is it in the typing ?
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
2 times, most recently
from
4616b50 to
b6b998b
Compare
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
from
b6b998b to
d303578
Compare
lolottetheclash
previously approved these changes
Nov 5, 2025
aTurmo
previously approved these changes
Nov 5, 2025
Tsiorifamonjena
previously approved these changes
Nov 5, 2025
ppprevost
dismissed stale reviews from Tsiorifamonjena, aTurmo, and lolottetheclash
via
5b9f728
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
3 times, most recently
from
c0f2e51 to
4c18cd1
Compare
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
from
4c18cd1 to
6244e7c
Compare
aTurmo
previously approved these changes
Nov 6, 2025
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
2 times, most recently
from
76b7647 to
f9c5ed6
Compare
ref: #TAPC-4728 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
feat/pci-rancher_enable-iam-auth_tapc-4728
branch
from
f9c5ed6 to
95f56c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-4728
Description
Ticket Reference: #...
Additional Information