Fix: handle regex in first triple subject#42
Open
je-bugshell wants to merge 1 commit into
Open
Conversation
findFirstSubject() was passing the raw #/.../# key into subjectToAsset(), which sent it as a literal SQL filter. Used FindEntitiesByType() with in-memory valueMatch() filtering instead, same approach as performWalk().
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findFirstSubject()was sending the raw#/.../#delimited key as aliteral SQL filter via
subjectToAsset(), so regex subjects on the firsttriple never matched anything.
subject.Regexpis set, this now usesFindEntitiesByType()andfilters in-memory with
valueMatch()/allAttrsMatch()instead — samepattern already used by
performWalk()andpredAndObject().Closes #41 (also related: owasp-amass/amass#1098)
Note
I'm not a Go developer, so this is AI-assisted. Would appreciate a careful
review. The fix stays within the existing single-root
Extract()design.Test plan
go test ./triples/ -v