Fix error logging for standalone module #3374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores the original format string for error logging for ModSecurity when compiled as a standalone module. Specifically, the format string has "[client %s]" back again: this is required for standalone modules as Apache is not present to implicitly log the client source IP address.
|
|
I have tested this on a standalone installation of ModSecurity v2.9.8 and can confirm that it restores client IP address logging as intended. |
|
A reminder to me (or to us 😄) - we should add more tests, eg. which will check standalone build (and test it...?) too. |
airween
approved these changes
May 9, 2025
| hostname, log_escape(msr->mp, r->uri), unique_id); | ||
| #else | ||
| ap_log_error(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO, 0, r->server, | ||
| "[client %s] ModSecurity: %s%s [uri \"%s\"]%s", msr->remote_addr ? msr->remote_addr : r->connection->remote_ip, str1, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR:
[client %s]back again: this is required for standalone modules as Apache is not present to implicitly log the client source IP address.why
It is essential for the client source IP address to be written to the error log. This is required for resolving false positives, monitoring, detecting attacks, and the majority of day to day WAF operations.
This PR fixes the bug introduced in an attempt to tidy error logging for Apache in PR #3192.
references
closes #3373