refactor: [DC-300] start reorganizing the structure of the main window relative to the "top bar"#12540
Draft
modSpike wants to merge 30 commits into
Draft
refactor: [DC-300] start reorganizing the structure of the main window relative to the "top bar"#12540modSpike wants to merge 30 commits into
modSpike wants to merge 30 commits into
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
new main win is currently empty. To show it uncomment #define USE_NEW_MAIN_WINDOW in owncloudgui.h
fleshing out the new MainWindow and MainWindowController to replace old stuff
…into refactor/dc-300
also fixes squish
also new simplified about view. Update functionality has been removed and it's just a widget now
also added the settings view to menu
removed hard deps on main window/account view in the RequestAuthenticationController, too.
still need to implement showing the folder wizard when selective sync is used, but for most common workflow it's working now.
got rid of the "legacy" modal dialog thing in account view updated addFolder handling to use *the same* impl no matter where it's called from refined the requestAuthenticationController to create its own widget instead of taking is as ctr arg since it only runs modal then dies asap
…er viewing one of the "modal" panels
the account wizard pops when you start without an account, or delete the last account. If you cancel out of the wizard with no accounts existing, now we have a placeholder view with action named "accounts" (so you can switch to other views in the gui as normal). The content is yet to be filled but the empty page shows correctly. also spent a LOT of time getting the more button to look right. I switched to using the more icon (whch I still don't like but it's better than text for now) and wow it was a pain to get it to look right in the toolbar. Lots of comments about the fixes = mini style changes via style sheets. I'd say it's pretty good at this point. a bit of cleanup too.
the avatar now "reverts" to the fake account icon after a modal operation, too
inject the account manager instead of using the singleton instance() (future benefit) make window and account manager qpointers and add nullchecks for posterity
there is also only one toolbar now as the focus just didn't move from the accounts toolbar to the "main" toolbar even with every trick in the book.
apparently Utility::isMac() doesn't always work
erikjv
requested changes
Jun 12, 2026
erikjv
left a comment
erikjv
left a comment
Contributor
There was a problem hiding this comment.
Please check all new files for the copyright header
Code looks fine, but I'll have to do some testing for the "feel".
| @@ -0,0 +1,50 @@ | |||
| #include "accountplaceholderwidget.h" | |||
| @@ -0,0 +1,13 @@ | |||
| #pragma once | |||
| <cursorShape>ArrowCursor</cursorShape> | ||
| </property> | ||
| <property name="text"> | ||
| <string notr="true">Copyright ownCloud GmbH (A Kiteworks Company)</string> |
Contributor
There was a problem hiding this comment.
I'd remove this. (C) is typically shown in the about dialog.
Contributor
Author
There was a problem hiding this comment.
this is out of scope for this round.
I'm not sure why it's there in the first place, not sure if all brands have a copyright in the about dialog and most important: I intentionally only changed bare minimum content of pre-existing panels (eg removing the about button from settings as it makes no sense when you can open it directly) to keep the focus on the general reorg.
The settings panel needs improvement overall, so that's when this can be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://kiteworks.atlassian.net/browse/DC-300