Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Unique constraint for duplicate child shares #41249

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented May 7, 2024

For Debugging

CREATE UNIQUE INDEX child_share_unique ON oc_share (share_with, parent) WHERE parent IS NOT NULL AND share_type = 2

Copy link

update-docs bot commented May 7, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@IljaN IljaN force-pushed the fix/child_share_constraint branch 2 times, most recently from 9b8a12a to 1807023 Compare May 7, 2024 15:04
@IljaN IljaN force-pushed the fix/child_share_constraint branch from 1807023 to 09cdafe Compare May 7, 2024 15:11
@IljaN

This comment was marked as resolved.

@IljaN IljaN force-pushed the fix/child_share_constraint branch from 0280578 to 1b5c5fa Compare May 7, 2024 17:17
@IljaN IljaN force-pushed the fix/child_share_constraint branch from 6192cd0 to 9a29ebb Compare May 8, 2024 08:59
@IljaN
Copy link
Member Author

IljaN commented May 8, 2024

  • Analyze if creating an index on the "parent" column makes sense as the unique-index uses a WHERE. Will this improve INSERT performance? Are indexes used by other indexes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants