Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TypeCheckSFTP.php #41309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

harrykipper
Copy link

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@harrykipper
Copy link
Author

Add changelog item for pull request 41240

@harrykipper harrykipper reopened this Aug 19, 2024
@iasdeoupxe
Copy link
Contributor

Shouldn't this go directly into #41240 and instead of changelog/unreleased/TypeCheckSFTP.php the file should be just called changelog/unreleased/41240?

@phil-davis
Copy link
Contributor

Yes, the changelog needs to go into PR #41240 - the file name of the changelog does not matter so much, but we have been conventionally using the PR number 41240 as the name of the changelog file.

@iasdeoupxe iasdeoupxe mentioned this pull request Sep 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants