Skip to content

feat: provision group membership based on userinfo#325

Open
bcskda wants to merge 1 commit intoowncloud:masterfrom
bcskda:master
Open

feat: provision group membership based on userinfo#325
bcskda wants to merge 1 commit intoowncloud:masterfrom
bcskda:master

Conversation

@bcskda
Copy link
Copy Markdown

@bcskda bcskda commented Sep 29, 2024

Description

Autoprovision groups based on userinfo

Adds a new auto-provision.groups-claim config parameter - the claim which holds the list of user's group IDs.
If set, change user's group membership accordingly. If not set, keep current behavior.
Unknown groups are ignored.

Related Issue

Motivation and Context

External group/role management via OIDC is widely used, but currently lacking in ownCloud.

How Has This Been Tested?

  • test environment: ~100 users installation (with modified unsigned oidc module), Keycloak 21+ for IdP
  • test case 1: add user to known Keycloak realm groups; login; check ownCloud group membership
  • test case 2: re-login; check group membership persists
  • test case 3: remove user from some Keycloak realm groups; re-login; check ownCloud group membership

Screenshots (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 29, 2024

CLA assistant check
All committers have signed the CLA.

@DeepDiver1975
Copy link
Copy Markdown
Member

Looks like the coding style is not respected and please add tests for this. THX

@messi89
Copy link
Copy Markdown

messi89 commented Mar 4, 2026

any news about this pr ?

@bcskda
Copy link
Copy Markdown
Author

bcskda commented Mar 7, 2026

I definitely lack qualification to proceed on this, so we'll probably keep using this as a downstream patch
To anyone willing to follow the same path: keep in mind this is security-related change which hasn't been positively reviewed by maintainers, so exercise caution (also the unsigned apps issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Autoprovision groups based on userinfo

4 participants