Skip to content

ci: enable codspeed simulation#565

Merged
Boshen merged 1 commit into
mainfrom
ci/codspeed-simulation-2
Jun 26, 2026
Merged

ci: enable codspeed simulation#565
Boshen merged 1 commit into
mainfrom
ci/codspeed-simulation-2

Conversation

@Boshen

@Boshen Boshen commented Jun 26, 2026

Copy link
Copy Markdown
Member

Sets CodSpeed benchmark workflows to simulation mode.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing ci/codspeed-simulation-2 (5ba4c99) with main (add2a54)

Open in CodSpeed

@Boshen Boshen marked this pull request as ready for review June 26, 2026 08:27
@Boshen Boshen merged commit 5798494 into main Jun 26, 2026
3 checks passed
@Boshen Boshen deleted the ci/codspeed-simulation-2 branch June 26, 2026 08:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ba4c99f1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- name: Run benchmark
uses: CodSpeedHQ/action@63f3e98b61959fe67f146a3ff022e4136fe9bb9c # v4.17.6
with:
simulation: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the ignored simulation input with mode

This new simulation key is not an input accepted by the pinned CodSpeedHQ/action composite action, so GitHub Actions will ignore it and the workflow still runs with mode: instrumentation. I checked the pinned action definition, which uses the mode input for simulation and describes instrumentation as the deprecated legacy name, with no simulation input declared: https://raw.githubusercontent.com/CodSpeedHQ/action/63f3e98b61959fe67f146a3ff022e4136fe9bb9c/action.yml. If the intent is to enable simulation mode and avoid the deprecated alias, this should update mode to simulation instead of adding a separate boolean.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant