ci: enable codspeed simulation#565
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ba4c99f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run benchmark | ||
| uses: CodSpeedHQ/action@63f3e98b61959fe67f146a3ff022e4136fe9bb9c # v4.17.6 | ||
| with: | ||
| simulation: true |
There was a problem hiding this comment.
Replace the ignored simulation input with mode
This new simulation key is not an input accepted by the pinned CodSpeedHQ/action composite action, so GitHub Actions will ignore it and the workflow still runs with mode: instrumentation. I checked the pinned action definition, which uses the mode input for simulation and describes instrumentation as the deprecated legacy name, with no simulation input declared: https://raw.githubusercontent.com/CodSpeedHQ/action/63f3e98b61959fe67f146a3ff022e4136fe9bb9c/action.yml. If the intent is to enable simulation mode and avoid the deprecated alias, this should update mode to simulation instead of adding a separate boolean.
Useful? React with 👍 / 👎.
Sets CodSpeed benchmark workflows to simulation mode.