Skip to content

ci: use codspeed mode input#566

Merged
Boshen merged 2 commits into
mainfrom
ci/codspeed-mode-simulation
Jun 26, 2026
Merged

ci: use codspeed mode input#566
Boshen merged 2 commits into
mainfrom
ci/codspeed-mode-simulation

Conversation

@Boshen

@Boshen Boshen commented Jun 26, 2026

Copy link
Copy Markdown
Member

Replaces the CodSpeed simulation input with mode: simulation.

@Boshen Boshen marked this pull request as ready for review June 26, 2026 08:45
@Boshen Boshen enabled auto-merge (squash) June 26, 2026 08:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8d481a4eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/benchmark.yml Outdated
Comment on lines 37 to 39
mode: simulation
run: cargo codspeed run
mode: instrumentation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the duplicate CodSpeed mode key

This with: block now defines mode twice, so parsers that accept duplicate YAML keys keep/redefine the later value (mode: instrumentation) and the action is not actually invoked with the new simulation value added here. The pinned CodSpeed action defines mode as the required input and marks instrumentation as the deprecated legacy name for simulation (see CodSpeedHQ/action at 63f3e98.../action.yml), so change the existing mode entry instead of adding a second one.

Useful? React with 👍 / 👎.

@Boshen Boshen disabled auto-merge June 26, 2026 10:05
@Boshen Boshen merged commit 836be76 into main Jun 26, 2026
@Boshen Boshen deleted the ci/codspeed-mode-simulation branch June 26, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant