Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minify alternated one child if block #7231

Draft
wants to merge 2 commits into
base: 11-10-feat_minifier_minify_one_child_if_statement_expression
Choose a base branch
from

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 10, 2024

No description provided.

Copy link

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 10, 2024
Copy link
Contributor Author

7086cmd commented Nov 10, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #7231 will not alter performance

Comparing 11-10-feat_minifier_minify_alternated_one_child_if_block (e2f5288) with 11-10-feat_minifier_minify_one_child_if_statement_expression (4ea0205)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor Author

7086cmd commented Nov 10, 2024

So we can assume it's a problem due to enabling a new peephole, same as #6698, #6266.

@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch 2 times, most recently from e9862e1 to 4ea0205 Compare November 11, 2024 08:41
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_alternated_one_child_if_block branch from 81612ea to e2f5288 Compare November 11, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant