Skip to content

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented) #7443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 19, 2025
Merged

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented) #7443

merged 9 commits into from
Feb 19, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 30, 2025

Pulled out of #7076

Exposes Affinity/Anti-Affinity Groups in the API, but as unimplemented.

@smklein smklein mentioned this pull request Jan 30, 2025
Closed
44 tasks
hawkw
hawkw approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me --- more or less precisely what I would expect based on what's specified in RFD 522. Nothing controversial here.

david-crespo
david-crespo approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.

andrewjstone
andrewjstone approved these changes Jan 31, 2025
View reviewed changes
@smklein smklein merged commit 18e317b into main Feb 19, 2025
17 checks passed
@smklein smklein deleted the affinity-api branch February 19, 2025 18:21
hawkw pushed a commit that referenced this pull request Feb 21, 2025
@smklein @hawkw
(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented) (
2add0db 
#7443)

Pulled out of #7076

Exposes Affinity/Anti-Affinity Groups in the API, but as unimplemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes

@hawkw hawkw hawkw approved these changes

@david-crespo david-crespo david-crespo approved these changes

@karencfv karencfv karencfv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smklein @andrewjstone @hawkw @david-crespo @karencfv