Skip to content

[4/n] [sled-agent] add code to read mupdate overrides #8081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: sunshowers/spr/main.sled-agent-add-code-to-read-mupdate-overrides
Choose a base branch
from

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented May 2, 2025

Don't make any decisions based on this at the moment -- simply read it for now. Decisions will happen in upcoming commits.

The logic here became quite complex, including tests, and I'm wondering if it would make sense to extract this into something more generic now or in the future.

Depends on:

Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the title [sled-agent] add code to read mupdate overrides [4/n] [sled-agent] add code to read mupdate overrides May 2, 2025
sunshowers added 5 commits May 2, 2025 11:46
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers added 4 commits May 6, 2025 08:38
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
@sunshowers sunshowers requested review from jgallagher and smklein May 8, 2025 03:48
@sunshowers sunshowers marked this pull request as ready for review May 8, 2025 03:48
@sunshowers
Copy link
Contributor Author

some review notes:

  • this is a pretty big one, though it's like 65% tests
  • I feel like we should extract this out into a common module at some point -- it feels like a somewhat different use case from Ledgerable though still related to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant