Add utxo to string from string #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yancyribbens
commented
Mar 14, 2025
•
yancyribbens
commented
- Implements FromStr for Utxo.
- Replace helper methods with FromStr trait
- Refactor Utxo using the builder pattern.
- Add constructors to UtxoPool
yancyribbens
force-pushed
the
add-utxo-to-string-from-string
branch
4 times, most recently
from
fb363f9 to
382c6ba
Compare
yancyribbens
force-pushed
the
add-utxo-to-string-from-string
branch
10 times, most recently
from
5f21b90 to
30c7d70
Compare
yancyribbens
force-pushed
the
add-utxo-to-string-from-string
branch
4 times, most recently
from
9a800b6 to
bd3fccb
Compare
Else branch isn't needed. If None is passed for expected_inputs and the results are Some, a panic will occur when expected_inputs is unwrapped.
Make use of FromStr trait in tests and remove redundant helper functions. In the process of refactoring, compare two vectors instead of casting the results to a String and then comparing the Strings.
Reduce code reuse by adding constructors
yancyribbens
force-pushed
the
add-utxo-to-string-from-string
branch
from
bd3fccb to
32c09e2
Compare
|
No changes to core algorithms or tests, just cleanup to the test-suit to make it nicer to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.