use accelerator for setCheckerboard in RHMC#379
Open
edbennett wants to merge 1 commit intopaboyle:developfrom
Open
use accelerator for setCheckerboard in RHMC#379edbennett wants to merge 1 commit intopaboyle:developfrom
edbennett wants to merge 1 commit intopaboyle:developfrom
Conversation
Owner
|
Hi -- I didn't merge this request because I was worried about the comments about non-understood parameter. |
Contributor
Author
|
Many thanks for the feedback—it'd be great to have a single performant implementation of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes some way towards #378. One-flavour RHMC is 10–20% faster with this, and gives identical results (i.e. generated configurations, excluding the header, are bitwise identical).
Things that could potentially be improved:
checker_dim_halfparameter toacceleratorSetCheckerboarddoes, so I have left it at the default value.setCheckerboardcould behave the same way; adding a dispatcher function inLattice_transfer.hthat implements the code in this PR in a single place, and then replacing all calls tosetCheckerboardwith calls to this new function would achieve this. However, I'm not set up to verify that the other calls tosetCheckerboardstill give correct results after this change, so I took the more conservative approach of just changing what I can confidently claim works.