Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate target/artifacts to release_artifacts to avoid cargo clean loss #374

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jan 24, 2024

in order to avoid glibc errors when compiling, it is necessary to run cargo clean prior to cross build as per solution 2 in this cross-rs issue

In doing so, it deletes the created target/artifacts folder.

We can either

  1. move release artifacts out of the target/artifacts folder
  2. use cargo clean -p <libname> --release which should in theory only delete the release artifacts for a particular target but I've not tested out if this works

I've elected for option 1

@rholshausen rholshausen merged commit 8b98286 into pact-foundation:master Jan 24, 2024
14 checks passed
@YOU54F YOU54F deleted the ci/cargo_clean branch January 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants