Fix add environment bootstrap#1847
Open
mamu0 wants to merge 8 commits into
Open
Conversation
Ensure dx add environment updates and applies the repository Terraform module so non-prod GitHub environments are provisioned with the expected policies. Also accept numeric resource prefixes when requesting Azure authorization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid rolling back add environment initialization while a newly created Key Vault endpoint is still propagating through DNS. Wait for the endpoint to resolve before writing runner app secrets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use an assertion that remains stable after lint autofix so the dx-cli Nx test target keeps passing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mamu0
force-pushed
the
fix-dx-add-environment
branch
from
e1b42f2 to
c993448
Compare
krusty93
reviewed
Jun 16, 2026
Contributor
question: What does "keep" mean? Is there any other way in our platform?
question: ? |
Co-authored-by: Andrea Grillo <andrea.grillo@pagopa.it>
Contributor
Author
I just meant that the workflow hasn't been changed; it modify the Terraform configuration and then apply it
That is a leftover modification from my local testing. The prefix now supports numbers as well, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
dx add environmentto add the selected environment to the repository Terraform module and apply it immediately..Now also accept numeric resource prefixes when requesting Azure authorization (e.g.
dxt0).Resolves CES-1989