feat(pn-15928): increased denomination max length to 88 characters #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaCimini90
requested review from
a team and
ZorbaDimatteo
as code owners
alessandrogelmi
requested changes
Nov 21, 2025
Collaborator
alessandrogelmi
left a comment
alessandrogelmi
left a comment
There was a problem hiding this comment.
The fix works, but the tests need to be fixed
Contributor
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Increased denomination max length to 88 characters
List of changes proposed in this pull request
How to test
Login with PA -> go to new notification and ad a PF recipient with first name and last name longer than 88 characters in total and check that error is shown -> add a PG recipient and do the same check -> fix the error adding 88 characters -> confirm the creation and check tat everything is ok