[Proposal] break(ContextMenu): Use React 18 rendering #7392
+52
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Concept] break(ContextMenu): Use React 18 renderingBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7165
Changes proposed in this pull request:
This PR proposes a changed API for the context menu imperative API to support React 18 rendering. In this API instead of having two different render and unmount functions we have a single function which renders the element and returns an unmount function. This allows a root node to be maintained between these functions so that we can use the React 18 rendering API.
If we're happy with this API then I've introduced a change here #7391 which implements this API in a non-breaking way, maintaining the old types and React 16 compatible rendering. Once that's in, I'll cherry pick onto
bp6and then update this PR and make it ready for review.