Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import hard-coded curry with ES2015 modules and Rollup #147

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Import hard-coded curry with ES2015 modules and Rollup #147

wants to merge 18 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2017

Switches from Ramba's curryN to Most.js (@most/prelude) hard-coded curry2 and curry3 implementations. Part of the rationale.

I also saw potential in size reduction comparing the implementations: the changes result in fact in a 32% size drop on a minified + gzipped build.

I replaced Browserify with Rollup, which has had the side-effect of bringing down the bundle size even further.

Edit: The changes need Node >= 4.0.0.

Keep Ramda as a devDependency because it is required in some tests.
We import flyd instead of the source because we are using an ES6 module, which is tree-shaken into fyld.js by Rollup.
Fix minor inconsistency in the source.
The changes result in a 32% size reduction for a minified + gzipped build.
Adjusted to ES6 module
Attempts to fix `undefined is not a function` for Node v.0.12.18.
@coveralls
Copy link

coveralls commented Apr 30, 2017

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 566c71f on flagello:improve_curry into 8e78338 on paldepind:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 90038e0 on flagello:improve_curry into 8e78338 on paldepind:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 90038e0 on flagello:improve_curry into 8e78338 on paldepind:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 8c3f25b on flagello:improve_curry into 8e78338 on paldepind:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 8c3f25b on flagello:improve_curry into 8e78338 on paldepind:master.

@coveralls
Copy link

coveralls commented Apr 30, 2017

Coverage Status

Coverage decreased (-0.9%) to 99.078% when pulling 93021f3 on flagello:improve_curry into 8e78338 on paldepind:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants