-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import hard-coded curry with ES2015 modules and Rollup #147
Open
ghost
wants to merge
18
commits into
paldepind:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep Ramda as a devDependency because it is required in some tests.
We import flyd instead of the source because we are using an ES6 module, which is tree-shaken into fyld.js by Rollup.
Fix minor inconsistency in the source.
Adjusted to ES6 module
Attempts to fix `undefined is not a function` for Node v.0.12.18.
1 similar comment
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from Ramba's
curryN
to Most.js (@most/prelude) hard-codedcurry2
andcurry3
implementations. Part of the rationale.I also saw potential in size reduction comparing the implementations: the changes result in fact in a 32% size drop on a minified + gzipped build.
I replaced Browserify with Rollup, which has had the side-effect of bringing down the bundle size even further.
Edit: The changes need Node >= 4.0.0.