Skip to content

Conversation

@dzpt
Copy link

@dzpt dzpt commented May 10, 2024

Due to #564 , if the debug is false in production, having cache system failure would ruin the whole app.
This is inconsistent compare to the exception handle in the @memoize decoration, which is allowed your app continue running even caching system (like redis) is down.

Checklist:

  • [ x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • [ x] Add or update relevant docs, in the docs folder and in code.
  • [ x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • [ x] Add .. versionchanged:: entries in any relevant code docs.
  • [ x] Run pre-commit hooks and fix any issues.
  • [ x] Run pytest and tox, no tests failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

jinja caching won't have exception while having redis failure

1 participant