fix: Mev toggle not shown when user doesnt have enough native and modal shown when changing chains #11339
Conversation
memoyil
requested review from
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
memoyil
changed the title
| @@ -100,26 +42,15 @@ async function fetchMEVStatus(walletClient: WalletClient): Promise<{ mevEnabled: | |||
| } | |||
| } | |||
|
|
|||
| export function useWalletSupportsAddEthereumChain() { | |||
There was a problem hiding this comment.
function not needed
| @@ -129,22 +60,20 @@ export function useIsMEVEnabled() { | |||
| (walletType !== WalletType.mevNotSupported && | |||
| (data?.mevEnabled || (walletType === WalletType.mevDefaultOnBSC && chainId === ChainId.BSC))) ?? | |||
| false, | |||
| isLoading, | |||
| isLoading: isPending || isLoading, | |||
There was a problem hiding this comment.
to not show toggle when in first render
| const { data, isLoading, refetch } = useQuery({ | ||
| queryKey: ['isMEVEnabled', walletClient, account, chainId, walletType], | ||
| const { data, isLoading, isPending, refetch } = useQuery({ | ||
| queryKey: ['isMEVEnabled', walletClient?.uid, account, chainId, walletType], |
There was a problem hiding this comment.
serializing the walletclient is a heavy operation, uid is enough to make it unique
| queryFn: () => fetchMEVStatus(walletClient!), | ||
| enabled: Boolean(account) && walletClient && chainId === ChainId.BSC, | ||
| enabled: Boolean(account && walletClient && chainId === ChainId.BSC), |
There was a problem hiding this comment.
when there is account but not walletclient (on initial render) enabled becomes undefined which makes query hook to be fetched with undefined walletclient. So the whole condition needs to be wrapped with boolean
| @@ -84,10 +28,8 @@ async function fetchMEVStatus(walletClient: WalletClient): Promise<{ mevEnabled: | |||
| method: 'eth_call', | |||
| params: [ | |||
| { | |||
| from: walletClient.account?.address ?? '0x', | |||
There was a problem hiding this comment.
user's address shouldnt be used, because it cannot correctly query if user doesn't have enough native token
| @@ -55,6 +56,12 @@ export const MevToggle: React.FC = () => { | |||
| }, | |||
| ) | |||
|
|
|||
| useEffect(() => { | |||
| if (!shouldShowMEVToggle) { | |||
There was a problem hiding this comment.
this is for to prevent, after adding the rpc modal isOpen stays true which results opening the modal again (without user clicking the toggle) when switching back to bsc (on some wallets it switches back to default rpc which results mev become disabled)
…al shown when changing chains
…al shown when changing chains
memoyil
force-pushed
the
feature/fix_mev_toggle_issues
branch
from
978cc93 to
eaef53a
Compare
PR-Codex overview
This PR introduces a
useEffecthook in theMevTogglecomponent to handle the visibility of the MEV toggle based on theshouldShowMEVTogglestate. It also removes theWalletProvidersarray and related functionality, streamlining the wallet support checks.Detailed summary
useEffectinMevToggleto dismiss toggle ifshouldShowMEVToggleis false.WalletProvidersarray andcheckWalletSupportAddEthereumChainfunction fromhooks/index.ts.useIsMEVEnabledto modify query parameters and conditions.useIsMEVEnabled.useShouldShowMEVToggle.