Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash info token pages #11358

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Mar 19, 2025


PR-Codex overview

This PR focuses on improving type safety and error handling in the TokenPage and PoolsTable components by refining the types of certain properties and implementing asynchronous data fetching with retry logic.

Detailed summary

  • Updated poolDatas type in PoolTableProps to PoolData[] | undefined.
  • Changed TokenQueryResponse structure in TokenPage.tsx to use undefined for token and pool.
  • Introduced atomWithAsyncRetry for fetching token data with error handling in both TokenPage.tsx and V3Info/TokenPage.tsx.
  • Updated fallback values for token, pool, transactions, and charts in the new async logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 9f216ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 6:29pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
blog ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
bridge ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
games ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
gamification ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
uikit ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:29pm
solana ⬜️ Skipped (Inspect) Apr 1, 2025 6:29pm
ton ⬜️ Skipped (Inspect) Apr 1, 2025 6:29pm

@memoyil memoyil force-pushed the feature/fix_crash_v3_info_token_page branch from c7d8923 to 756e412 Compare April 1, 2025 17:38
@memoyil memoyil requested a review from chefphilip as a code owner April 1, 2025 17:38
@vercel vercel bot temporarily deployed to Preview – solana April 1, 2025 17:38 Inactive
@vercel vercel bot temporarily deployed to Preview – ton April 1, 2025 17:38 Inactive
@memoyil memoyil changed the title fix: Crash v3 info token page fix: Crash info token pages Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant