Draft
Conversation
09adb6f to
2fd6657
Compare
2fd6657 to
283d6b6
Compare
283d6b6 to
5beca26
Compare
d903484 to
b50de35
Compare
b50de35 to
1669043
Compare
1669043 to
58ee723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
The objective is to merge the Chaff bugs into the main branch. The ideal is to have LAVA and Chaff bugs injected simultaneously. Here is the paper.
Links to refer to Zhenghao's code:
This is on his Chaff Repo
HighW4y2H3ll/chaff@master...x64
HighW4y2H3ll/chaff@61faa5d...master
Original FIB:
https://github.com/HighW4y2H3ll/chaff/blob/master/tools/fbi/src/find_bug_inj.cpp
Note: I do NOT attempt to re-implement the heap-based overflows chaff bug, as this requires glibc 2.24, which uses a really old heap allocator and is therefore difficult to replicate. In a future PR, I will attempt to see if there is a generalized way, regardless of the heap allocator, to get this chaff bug.
...
Test plan
We should add tests where LAVA only injects chaff bugs and confirm that yes, it can't be exploited.
We should also confirm that both LAVA and Chaff bugs can be injected concurrently.
...
Closing issues
N/A
...