Fix color configuration and refactor CanvasBoard for readability#46
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and unifies the color inversion logic across the canvas, properties panel, and sidebar components to ensure consistent color handling in both light and dark themes. It removes legacy color inversion code, centralizes the color inversion logic, and improves the user experience when selecting background and stroke colors. The changes also introduce theme-specific background swatches and update the UI to reflect the selected colors accurately.
Color inversion and theme consistency:
CanvasBoard.tsx,Left3bar.tsx, andPropertiesPanel.tsxto use a unifiedinvertHexColorfunction that handles both 3-digit and 6-digit hex codes, ensuring consistent color display and storage in dark and light modes. [1] [2]Sidebar and background color improvements:
Left3bar.tsxby removing the old inversion logic and introducing separate light and dark color swatch arrays, automatically switching the default background color when the theme changes.Code cleanup and minor UI tweaks:
These changes ensure a more predictable and visually consistent color experience for users across all components, regardless of the selected theme.