-
-
Notifications
You must be signed in to change notification settings - Fork 143
GH1230 Improve types for pd.options.display.* properties #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in tests. I don't have time right now to verify the changes to the types in Display
- will do that in next review.
7c1f996
to
ea52252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request as we are already touching the code here, otherwise looking in line with the pandas docs.
Co-authored-by: Loic Diridollou <[email protected]>
1431b83
to
c92510f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mike-flowers-airbnb
assert_type()
to assert the type of any return valueUpdated based off documentation in config_init.py
Let me know if you'd like me to update the second test to also use
assert_type
on each value.