Add type parameters to generics in isna and notna #945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()
to assert the type of any return valueThis is to fix issues with pyright strict mode which complains about partially unknown types.
I verified that this test fails in strict mode without these changes and passes with them.
There are still some points i am unsure about:
Any
or an (unbounded?)TypeVar
(or maybe i should useIncomplete
?)ArrayLike
annotation into its components to add the type parameters to the ndarray. While i did also change it in thepandas-stubs/_typing.pyi
, it was still importing them from the actual pandas.