-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Improve ImportError message to suggest importing dependencies directly for full error details #61084
Open
chilin0525
wants to merge
10
commits into
pandas-dev:main
Choose a base branch
from
chilin0525:improve_error_message_for_missing_dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BUG: Improve ImportError message to suggest importing dependencies directly for full error details #61084
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
41c3481
Add hint to display full message for missing dependencies in pandas/i…
chilin0525 a46dc65
Merge branch 'main' into improve_error_message_for_missing_dependencies
chilin0525 0267293
ENH: Improve import error handling to preserve original traceback
chilin0525 d65a970
Merge branch 'main' into improve_error_message_for_missing_dependencies
chilin0525 51826c0
TST: refactor testing for hard dependency package
chilin0525 2fa208d
Update pandas/__init__.py
chilin0525 734a707
Refactor prevent statement too long
chilin0525 4efb33a
Merge branch 'main' into improve_error_message_for_missing_dependencies
chilin0525 17dae60
Merge branch 'main' into improve_error_message_for_missing_dependencies
chilin0525 5f5ab6a
ENH: change unittest to verify ImportError is raised when required de…
chilin0525 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we monkeypatch
_hard_dependencies
with a fake module and test that instead? I'm worried about this test having side effects by modifyingsys.modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, modifying
sys.modules
directly is not an ideal approach.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 5f5ab6a. Instead of monkeypatching
_hard_dependencies
, I mockedbuiltins.__import__
to raise anImportError
when a specific dependency is imported. This approach was chosen because reloading pandas withimportlib.reload()
resets the module, which would override any monkeypatch applied to_hard_dependencies
.If there's a better approach, I'm happy to consider it.