Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Updated link for OVH server benchmark visualization #61108

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jackbtlr
Copy link

@jackbtlr jackbtlr commented Mar 12, 2025

Comment on lines 39 to 41
- Original server: [asv](https://asv-runner.github.io/asv-collection/pandas/)
- OVH server: [asv](https://pandas.pydata.org/benchmarks/asv/) (benchmarks results can
also be visualized in this [Conbench PoC](http://57.128.112.95:5000/)
also be visualized in this [GitHub Pages site](https://pandas-dev.github.io/asv-runner/))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhshadrach IIUC based on https://github.com/pandas-dev/asv-runner we are just runnning the benchmarks on Github Actions now right? If so, we just need https://pandas-dev.github.io/asv-runner/ here right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the status of the original server point, but if conbench isn't available anymore, we can just remove the comment in brackets. The - OVH server: asv bullet point is still relevant. We do run the benchmarks there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datapythonista - why are we running benchmarks there? Is someone looking at them?

I would like a link to the current ASV page that is being maintained (by me, the 2nd link in @mroeschke's comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, I missed this. I may have partial information, but what I know is that Wes had a machine at home where benchmarks were running. When he moved he sent it to Tom, but we didn't consider this approach reliable, and we wanted to have them running in a data center, not in someone's home. When we signed the agreement with OVH we set them up there. The idea was also to try to make them as fast as possible, so we could run them in PRs. A decent amount of work was done in that direction, but funds were over before we could make them fast enough.

So, if I'm not wrong, what we want in this page is to keep the Original server entry as it's Tom's machine. Add an item in the list for the benchmarks running in GitHub Actions that Matt mentions. And keep the OVH server entry, which I guess should have the most stable results.

Does that sound good?

@mroeschke mroeschke added the Docs label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Conbench PoC benchmark is down
4 participants