BUG: Handle overlapping line and scatter on the same plot #61244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract and streamline time series preparation steps into `prepare_ts_data`, replacing redundant logic across methods. Simplifies axis frequency handling and improves code readability while maintaining functionality.
This test ensures that the x-axis ticks are consistent between scatter and line plots when sharing the same axis. It addresses a potential issue related to GH#61005, verifying proper rendering of datetime x-axis labels.
This resolves an issue where line and scatter plots were not aligned when using Series.plot. The fix ensures proper alignment and improves plot consistency. Refer to issue pandas-dev#61005 for further details.
Datetime.time is now supported in scatter plots due to added converter implementation in ScatterPlot. Removed the test expecting a TypeError and updated it to validate the new functionality.
Simplify and streamline the code by directly assigning x_data from the data variable and replacing the intermediate Series object with a clearer `s` variable. This improves readability and maintains the existing functionality.
Relocated the `test_scatter_line_xticks` test from `test_series.py` to `test_frame.py` for better alignment with DataFrame-specific functionality. This refactor ensures the test resides in the appropriate context based on its usage and focus.
mroeschke
reviewed
Apr 8, 2025
| @@ -366,3 +364,17 @@ def format_dateaxis( | |||
| raise TypeError("index type not supported") | |||
|
|
|||
| plt.draw_if_interactive() | |||
|
|
|||
|
|
|||
| def prepare_ts_data(data, ax, kwds): | |||
There was a problem hiding this comment.
Is it possible to type this function?
mroeschke
reviewed
Apr 8, 2025
Comment on lines
852
to
855
| datetime_list = [datetime(year=2025, month=1, day=1, hour=n) for n in range(3)] | ||
| df = DataFrame(columns=["datetime", "y"]) | ||
| for i, n in enumerate(datetime_list): | ||
| df.loc[len(df)] = [n, i] |
There was a problem hiding this comment.
Could you create this in 1 call? i.e. pass a dict to DataFrame
There was a problem hiding this comment.
I created it by passing a list
mroeschke
reviewed
Apr 8, 2025
pandas/plotting/_matplotlib/core.py
Outdated
| @@ -54,6 +54,7 @@ | |||
| ) | |||
| from pandas.core.dtypes.missing import isna | |||
|
|
|||
| from pandas import Series | |||
There was a problem hiding this comment.
Can we conditionally import this where used?
Added precise type annotations to the function signature for better clarity and type checking. Replaced `data` with `series` and `kwds` with `kwargs` to enhance readability and consistency.
The DataFrame creation in the test has been streamlined for clarity and conciseness by replacing the loop with a list comprehension. This improves code readability and maintains the same functionality.
Moved the `Series` import inside relevant function scopes to minimize unnecessary top-level imports and align with existing import patterns. This helps improve code readability and ensures imports are only loaded where needed.
Moved the import of `Series` within the `_make_plot` method to comply with styling or runtime considerations. This ensures consistency and avoids potential import-related issues.
|
@mroeschke Thanks for the feedback; I applied your comments. |
mroeschke
approved these changes
Apr 9, 2025
|
Thanks @MartinBraquet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Running the code from the issue above now shows a correct plot.