BUG: Make Series flex methods raise NotImplementedError for bool dtypes #63332
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementedError for bool dtypes This change ensures that flex methods like .truediv(), .rtruediv(), .floordiv(), .rfloordiv(), .pow(), .rpow() raise NotImplementedError for boolean dtypes, consistent with their dunder method counterparts (__truediv__, etc.). Previously, pd.Series([True]).truediv([True]) would return a float result, while pd.Series([True]) / [True] would raise NotImplementedError. This fixes the inconsistency by routing _binop through ops.arithmetic_op which includes the bool dtype check. Closes pandas-dev#63250
Member
|
Can you add tests (applies to all your PRs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the inconsistency between Series flex methods (
.truediv(),.floordiv(), etc.) and their dunder counterparts (__truediv__,__floordiv__, etc.) when operating on boolean dtypes.Previously:
pd.Series([True]) / [True]raisedNotImplementedError✓pd.Series([True]).truediv([True])returned a float result ✗After this fix, both methods consistently raise
NotImplementedError: operator 'truediv' not implemented for bool dtypes.Changes
Modified
Series._binop()to route throughops.arithmetic_op()instead of directly calling the operator function. This ensures the_bool_arith_checkis applied consistently for all arithmetic operations.The fix applies to all disallowed operations for bool dtypes:
truediv/rtruedivfloordiv/rfloordivpow/rpowdivmod/rdivmodTest Plan
pd.Series([True]).truediv([True])now raisesNotImplementedErrorpd.Series([True]).rtruediv([True])now raisesNotImplementedErrorpd.Series([True]).floordiv([True])now raisesNotImplementedErrorpd.Series([True]).pow([True])now raisesNotImplementedErrorpd.Series([1.0]).truediv([2.0])returns[0.5]Closes #63250