Skip to content

STY: Add strict parameter to zip() in pandas/core/reshape/concat #63350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 3 commits into from
Dec 14, 2025
Merged

STY: Add strict parameter to zip() in pandas/core/reshape/concat #63350

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f29a3dc
STY: add strict parameter to changes from issue 62843
Unkwn1 Dec 13, 2025
02fcdab
STY: cleanup formating
Unkwn1 Dec 13, 2025
8d56559
STY: changed zip() to pairwise() for improved readability and adhere …
Unkwn1 Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pandas/core/reshape/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,17 @@ def concat(
intersect
or any(not isinstance(index, DatetimeIndex) for index in non_concat_axis)
or all(
prev is curr for prev, curr in zip(non_concat_axis, non_concat_axis[1:])
prev is curr
for prev, curr in zip(
Copy link
Member

@mroeschke mroeschke Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use itertools.pairwise for both changes?

non_concat_axis, non_concat_axis[1:], strict=False
)
)
or (
all(
prev[-1] <= curr[0] and prev.is_monotonic_increasing
for prev, curr in zip(non_concat_axis, non_concat_axis[1:])
for prev, curr in zip(
non_concat_axis, non_concat_axis[1:], strict=False
)
if not prev.empty and not curr.empty
)
and non_concat_axis[-1].is_monotonic_increasing
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ exclude = [
"pandas/core/groupby/grouper.py" = ["B905"]
"pandas/core/groupby/ops.py" = ["B905"]
"pandas/core/methods/to_dict.py" = ["B905"]
"pandas/core/reshape/concat.py" = ["B905"]
"pandas/core/reshape/encoding.py" = ["B905"]
"pandas/core/reshape/melt.py" = ["B905"]
"pandas/core/reshape/merge.py" = ["B905"]
Expand Down
Loading