Skip to content

Conversation

@hummuscience
Copy link
Contributor

This is a draft pull request for adding the weighted random sampling option as suggested here: #158 (comment)

I am not very experienced with coding and good practices (typical biologist background :D) so I put this together with the help of an LLM.

For some reason, I was unable to pass the config setting to the function. Am I missing something? This is the reason it's currently set to be enabled by default. Technically, even when its turned on, it should still work normally for data that is not unbalanced, right?

I also added a test to check if the functionality works. Even though, it makes more sense to add a test with an unbalanced dataset as input and check that the outputs are correct. Right?

Also, I am not sure yet how well this works with the suggestion to use the COCO input for heterogenous datasets: #263

As I said, not much experience here and would love some input on how to do this right.

I am also open for a meeting (as @themattinthehatt suggested) to discuss this and also adding the top_view_mouse model to LP.

@themattinthehatt
Copy link
Collaborator

Thanks for the PR @hummuscience! Happy to take a closer look soon. I'm a bit swamped until mid-May with end of semester/deadlines, but after that let's definitely plan to meet and discuss further (both this PR and the top_view_mouse model). This work will actually dovetail quite nicely with the COCO input for heterogeneous datasets issue.

@themattinthehatt themattinthehatt self-requested a review April 24, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants