Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple network addresses binding #578

Merged
merged 7 commits into from
Apr 21, 2024
Merged

Conversation

panjf2000
Copy link
Owner

Fixes #428

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 85.46256% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 78.73%. Comparing base (3860208) to head (a746776).
Report is 1 commits behind head on dev.

Files Patch % Lines
engine_unix.go 85.50% 4 Missing and 6 partials ⚠️
acceptor_windows.go 84.21% 2 Missing and 4 partials ⚠️
gnet.go 89.28% 3 Missing and 3 partials ⚠️
listener_windows.go 28.57% 5 Missing ⚠️
connection_windows.go 60.00% 0 Missing and 4 partials ⚠️
connection_unix.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #578   +/-   ##
=======================================
  Coverage   78.72%   78.73%           
=======================================
  Files          25       25           
  Lines        2186     2248   +62     
=======================================
+ Hits         1721     1770   +49     
- Misses        322      331    +9     
- Partials      143      147    +4     
Flag Coverage Δ
unittests 78.73% <85.46%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit bf7121d into dev Apr 21, 2024
33 checks passed
@panjf2000 panjf2000 deleted the multi-listeners branch April 21, 2024 06:17
leslie-fei pushed a commit to leslie-fei/gnet that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: multiple addresses binding
1 participant