fix: unarchive fails for user id != 1000

[borismw]

Refers to issue #239. If the paperless_ngx_conf_usermap_uid variable is set to an id different from 1000, the unarchive fails to unpack files and change their ownership. This seems to be because the user unpacking the archive is different from the one owning the files.

This PR adds a lookup step to find out the correct user name with id == 1000 in cause paperless_ngx_conf_usermap_uid != 1000. The user name stored in the variable _paperless_ngx_untar_username will then later be used as the become_user in the unarchive step.

Note that with this solution

• if there's no user with id 1000 yet
• and paperless_ngx_conf_usermap_uid is not defined
  the lookup step will fail even though the user might perchance be created with the id 1000.

In order to prevent this one might to either have to move the system user creation step to an earlier stage or make paperless_ngx_conf_usermap_uid mandatory. I was not sure if it was okay to go down any of these routes.

[Copilot]

Pull Request Overview

This PR fixes an issue where unarchiving fails when the paperless_ngx_conf_usermap_uid is set to a value different from 1000. The fix involves determining the correct username for user ID 1000 and using it as the become_user for unarchive operations.

• Adds logic to lookup the username for user ID 1000 when paperless_ngx_conf_usermap_uid is not 1000
• Updates unarchive tasks to use the determined username as become_user
• Modifies permission handling to work with the new unarchive approach

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
tasks/preparation/platform.yml	Adds username lookup logic for user ID 1000 based on paperless_ngx_conf_usermap_uid configuration
tasks/paperless_ngx/release_files.yml	Updates unarchive process to use determined username and adjusts permission handling
tasks/base_dependencies/python.yml	Applies the same unarchive fix for Python source downloads

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

This line assumes that the getent query will always return exactly one result with UID 1000. If no user with UID 1000 exists, accessing [0] will cause an IndexError. Add error handling or validation to ensure the query returns results before accessing the first element.

[Copilot]

The comparison uses string \"1000\" in line 31 but integer comparison in line 26. This inconsistency could lead to unexpected behavior if paperless_ngx_conf_usermap_uid is defined as an integer. Use consistent data types for comparison, preferably converting to string or integer consistently.

Suggested change

	when: (paperless_ngx_conf_usermap_uid is undefined) or paperless_ngx_conf_usermap_uid != "1000"
	- name: Set fact username for user with id 1000
	ansible.builtin.set_fact:
	_paperless_ngx_untar_username: "{{ paperless_ngx_system_user }}"
	when: (paperless_ngx_conf_usermap_uid is defined) and paperless_ngx_conf_usermap_uid == "1000"
	when: (paperless_ngx_conf_usermap_uid is undefined) or (paperless_ngx_conf_usermap_uid | string) != "1000"
	- name: Set fact username for user with id 1000
	ansible.builtin.set_fact:
	_paperless_ngx_untar_username: "{{ paperless_ngx_system_user }}"
	when: (paperless_ngx_conf_usermap_uid is defined) and (paperless_ngx_conf_usermap_uid | string) == "1000"

[Copilot]

The comparison uses string \"1000\" in line 31 but integer comparison in line 26. This inconsistency could lead to unexpected behavior if paperless_ngx_conf_usermap_uid is defined as an integer. Use consistent data types for comparison, preferably converting to string or integer consistently.

Suggested change

	when: (paperless_ngx_conf_usermap_uid is undefined) or paperless_ngx_conf_usermap_uid != "1000"
	- name: Set fact username for user with id 1000
	ansible.builtin.set_fact:
	_paperless_ngx_untar_username: "{{ paperless_ngx_system_user }}"
	when: (paperless_ngx_conf_usermap_uid is defined) and paperless_ngx_conf_usermap_uid == "1000"
	when: (paperless_ngx_conf_usermap_uid is undefined) or (paperless_ngx_conf_usermap_uid | string) != "1000"
	- name: Set fact username for user with id 1000
	ansible.builtin.set_fact:
	_paperless_ngx_untar_username: "{{ paperless_ngx_system_user }}"
	when: (paperless_ngx_conf_usermap_uid is defined) and (paperless_ngx_conf_usermap_uid | string) == "1000"

[Copilot]

Typo in task name: 'Pepare' should be 'Prepare' and 'untaring' should be 'untarring'.

Suggested change

	- name: Pepare permissions of tmp dir for untaring paperless-ngx sources
	- name: Prepare permissions of tmp dir for untarring paperless-ngx sources

[Copilot]

Typo in task name: 'Pepare' should be 'Prepare'.

Suggested change

	- name: Pepare permissions of tmp dir for unarchiving python sources
	- name: Prepare permissions of tmp dir for unarchiving python sources