feat(deck): polish Deck UI and capture harness#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish the Steam Deck preview shell and add a repeatable Game Mode capture harness for validating the 1280×800 Deck experience.
This PR focuses on the Deck UI/harness slice after the no-network stream/media groundwork landed separately. It keeps the review surface to Deck preview UI, layout/focus polish, capture tooling, and focused tests.
Scope included
clients/deck/qml/Main.qml: preview UI polish, clearer non-executable copy, focus/readability improvements, and 1280×800 Deck-oriented layout adjustments.clients/deck/src/deck_layout.cpp: layout model updates for Deck preview affordances.clients/deck/tests/deck_layout_test.cpp: coverage for the refreshed layout/copy contract.clients/deck/scripts/deck_gamemode_capture.py: Game Mode capture helper that selects the real 1280×800 Deck window and fails closed on ambiguous/helper windows.clients/deck/tests/deck_gamemode_capture_test.py: harness behavior tests.clients/deck/CMakeLists.txt: registers the capture harness test alongside the existing Deck CTest suite.Explicitly not included
Validation
git diff --check origin/master...HEAD -- clients/deckpython3 clients/deck/tests/deck_gamemode_capture_test.pypython3 clients/deck/scripts/deck_gamemode_capture.py --self-testcmake -S clients/deck -B build/deck-qt-smoke-pr-a-refresh -DNOVA_DECK_BUILD_QT_SHELL=ON -DCMAKE_BUILD_TYPE=Debugcmake --build build/deck-qt-smoke-pr-a-refreshctest --test-dir build/deck-qt-smoke-pr-a-refresh --output-on-failureSafety notes
The capture helper is local validation tooling. It uses desktop/window inspection and screenshot commands only for proof capture, hides the cursor, and fails closed when the target window is missing or ambiguous. It does not start streaming, pair hosts, or launch games.