feat: add era import persistence commit #16059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
commented
May 4, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
mattsse
reviewed
May 6, 2025
There was a problem hiding this comment.
this should work, but I think this has side-effects if used from within a pipeline stage where we need to adhere to some rules when it comes to when we are allowed to open certain writers and commit,
but I can't fully remember what those are so we need to figure this out first.
@RomanHodulak we're definitely missing commit calls in the standalone import fn, so I think the challenge is now unifying this with the stage impl
2 tasks
github-actions
bot
added
the
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #15982 that was wrongly open from
mainbranch.Prep for #15909.
It adds file storage/db persistence per file,
and then a global db commit at the end of the import.cc @RomanHodulak, @mattsse.