Skip to content

feat: Add support for ethstats #16396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Add support for ethstats #16396

wants to merge 1 commit into from

Conversation

fantasyup
Copy link
Contributor

closes #15264

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 21, 2025
@fantasyup fantasyup marked this pull request as draft May 21, 2025 14:49
graphite-app[bot]
graphite-app bot reviewed May 21, 2025
View reviewed changes
mattsse
mattsse requested changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start

structurally this is already looking great

the main loop we can write this as

pub async fn run(mut self) {
  loop {
     // maybe if we need to handle multiple things concurrently
    tokio::select! {


}


     }
}

crates/node/ethstats/src/ethstats.rs
Comment on lines +26 to +37
// URL argument should be of the form <nodename:secret@host:port>
// Split into credentials and address
let (cred_part, addr_part) = url.split_once('@').ok_or(Error::InvalidUrl)?;

// Split credentials: nodename:secret
let (nodename, secret) = cred_part.split_once(':').ok_or(Error::InvalidUrl)?;

// Split address: host:port
let (host, port_str) = addr_part.split_once(':').ok_or(Error::InvalidUrl)?;
let port: u16 = port_str.parse().map_err(|_| Error::InvalidPort)?;

Ok(Self { node: nodename.to_string(), pass: secret.to_string(), host: host.to_string(), port })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should extract these fields into a standalone type and add a fromstr impl for this

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@mattsse mattsse mattsse requested changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Reth Tracker
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ethstats client
2 participants
@fantasyup @mattsse