Skip to content

feat: add constructors for BSC upgrade status disable_peer_tx_broadcast flag #19270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add constructors for BSC upgrade status disable_peer_tx_broadcast flag #19270

wants to merge 6 commits into from
+104 −6

Conversation

@DeVikingMark
Copy link
Contributor

Description

Implements support for disable_peer_tx_broadcast flag by adding constructor methods and removing TODO comment.

Changes

  • Add UpgradeStatusExtension constructors: new(), allow_broadcast(), disable_broadcast()
  • Add UpgradeStatus constructors: new(), allow_broadcast(), disable_broadcast()
  • Update handshake to use new constructors
  • Remove TODO comment from UpgradeStatusExtension
  • Add tests

@DeVikingMark DeVikingMark requested a review from gakonst as a code owner October 23, 2025 23:47
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 23, 2025
@DeVikingMark DeVikingMark marked this pull request as draft October 23, 2025 23:53
@DeVikingMark DeVikingMark marked this pull request as ready for review October 24, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DeVikingMark