Skip to content

refactor: remove unused prune_modes from backfill jobs #19289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

refactor: remove unused prune_modes from backfill jobs #19289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98e8787
Update stream.rs
avorylli Oct 25, 2025
1b31bb9
Remove prune_modes from BackfillJobFactory
avorylli Oct 25, 2025
fe400e9
Remove prune_modes from BackfillJob struct
avorylli Oct 25, 2025
75dac6c
Update Cargo.toml
avorylli Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/exex/exex/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ reth-node-core.workspace = true
reth-primitives-traits.workspace = true
reth-ethereum-primitives.workspace = true
reth-provider.workspace = true
reth-prune-types.workspace = true
reth-revm.workspace = true
reth-stages-api.workspace = true
reth-tasks.workspace = true
Expand Down Expand Up @@ -76,7 +75,6 @@ serde = [
"rand/serde",
"secp256k1/serde",
"reth-primitives-traits/serde",
"reth-prune-types/serde",
"reth-config/serde",
"reth-ethereum-primitives/serde",
"reth-chain-state/serde",
Expand Down
10 changes: 0 additions & 10 deletions crates/exex/exex/src/backfill/factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use std::{ops::RangeInclusive, time::Duration};

use alloy_primitives::BlockNumber;
use reth_node_api::FullNodeComponents;
use reth_prune_types::PruneModes;
use reth_stages_api::ExecutionStageThresholds;

use super::stream::DEFAULT_PARALLELISM;
Expand All @@ -13,7 +12,6 @@ use super::stream::DEFAULT_PARALLELISM;
pub struct BackfillJobFactory<E, P> {
evm_config: E,
provider: P,
prune_modes: PruneModes,
thresholds: ExecutionStageThresholds,
stream_parallelism: usize,
}
Expand All @@ -24,7 +22,6 @@ impl<E, P> BackfillJobFactory<E, P> {
Self {
evm_config,
provider,
prune_modes: PruneModes::default(),
thresholds: ExecutionStageThresholds {
// Default duration for a database transaction to be considered long-lived is
// 60 seconds, so we limit the backfill job to the half of it to be sure we finish
Expand All @@ -38,12 +35,6 @@ impl<E, P> BackfillJobFactory<E, P> {
}
}

/// Sets the prune modes
pub const fn with_prune_modes(mut self, prune_modes: PruneModes) -> Self {
self.prune_modes = prune_modes;
self
}

/// Sets the thresholds
pub const fn with_thresholds(mut self, thresholds: ExecutionStageThresholds) -> Self {
self.thresholds = thresholds;
Expand All @@ -66,7 +57,6 @@ impl<E: Clone, P: Clone> BackfillJobFactory<E, P> {
BackfillJob {
evm_config: self.evm_config.clone(),
provider: self.provider.clone(),
prune_modes: self.prune_modes.clone(),
range,
thresholds: self.thresholds.clone(),
stream_parallelism: self.stream_parallelism,
Expand Down
2 changes: 0 additions & 2 deletions crates/exex/exex/src/backfill/job.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use reth_provider::{
BlockReader, Chain, ExecutionOutcome, HeaderProvider, ProviderError, StateProviderFactory,
TransactionVariant,
};
use reth_prune_types::PruneModes;
use reth_revm::database::StateProviderDatabase;
use reth_stages_api::ExecutionStageThresholds;
use reth_tracing::tracing::{debug, trace};
Expand All @@ -31,7 +30,6 @@ pub(super) type BackfillJobResult<T> = Result<T, BlockExecutionError>;
pub struct BackfillJob<E, P> {
pub(crate) evm_config: E,
pub(crate) provider: P,
pub(crate) prune_modes: PruneModes,
pub(crate) thresholds: ExecutionStageThresholds,
pub(crate) range: RangeInclusive<BlockNumber>,
pub(crate) stream_parallelism: usize,
Expand Down
5 changes: 0 additions & 5 deletions crates/exex/exex/src/backfill/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use reth_evm::{
use reth_node_api::NodePrimitives;
use reth_primitives_traits::RecoveredBlock;
use reth_provider::{BlockReader, Chain, StateProviderFactory};
use reth_prune_types::PruneModes;
use reth_stages_api::ExecutionStageThresholds;
use reth_tracing::tracing::debug;
use std::{
Expand Down Expand Up @@ -55,7 +54,6 @@ type BatchBlockStreamItem<N = EthPrimitives> = Chain<N>;
pub struct StreamBackfillJob<E, P, T> {
evm_config: E,
provider: P,
prune_modes: PruneModes,
range: RangeInclusive<BlockNumber>,
tasks: BackfillTasks<T>,
parallelism: usize,
Expand Down Expand Up @@ -178,7 +176,6 @@ where
let job = Box::new(BackfillJob {
evm_config: this.evm_config.clone(),
provider: this.provider.clone(),
prune_modes: this.prune_modes.clone(),
thresholds: this.thresholds.clone(),
range,
stream_parallelism: this.parallelism,
Expand All @@ -205,7 +202,6 @@ impl<E, P> From<SingleBlockBackfillJob<E, P>> for StreamBackfillJob<E, P, Single
Self {
evm_config: job.evm_config,
provider: job.provider,
prune_modes: PruneModes::default(),
range: job.range,
tasks: FuturesOrdered::new(),
parallelism: job.stream_parallelism,
Expand All @@ -224,7 +220,6 @@ where
Self {
evm_config: job.evm_config,
provider: job.provider,
prune_modes: job.prune_modes,
range: job.range,
tasks: FuturesOrdered::new(),
parallelism: job.stream_parallelism,
Expand Down
Loading