fix(provider): gate rocksdb jemalloc behind feature flag#23061
Merged
Conversation
rocksdb's jemalloc feature was unconditionally enabled in reth-provider, making it impossible for downstream crates to opt out. This gates it behind a `jemalloc` feature on reth-provider and propagates it through `reth-ethereum` and `bin/reth`. Co-Authored-By: Dan Cline <6798349+Rjected@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019cf915-e035-7749-80a8-66176bb08b4c
decofe
requested review from
Rjected,
joshieDo,
mattsse,
shekhirin and
yongkangc
as code owners
Contributor
|
shekhirin
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the issue where
reth-providerunconditionally enablesrocksdb/jemalloc, making it impossible for downstream crates (e.g. e2e tests) to build without jemalloc.reth-providernow has ajemallocfeature that gatesrocksdb/jemalloc. The feature is propagated throughreth-ethereumandbin/rethso existing builds are unaffected — jemalloc is still on by default for therethbinary.Co-Authored-By: Dan Cline 6798349+Rjected@users.noreply.github.com
Prompted by: Dan