fix(engine): propagate fatal errors from payload validation in on_downloaded_block#23072
Closed
mediocregopher wants to merge 2 commits intomainfrom
Closed
fix(engine): propagate fatal errors from payload validation in on_downloaded_block#23072mediocregopher wants to merge 2 commits intomainfrom
mediocregopher wants to merge 2 commits intomainfrom
Conversation
…nloaded_block Previously, InsertPayloadError::Payload errors were silently dropped in on_downloaded_block, while InsertPayloadError::Block errors were properly handled. This meant fatal errors (e.g. provider errors) wrapped in NewPayloadError::Other would be ignored, leaving the engine tree task alive but unable to execute blocks — causing the node to stall indefinitely instead of exiting. This can occur when validate_block_with_state fails during EVM environment construction (evm_env_for), which converts provider errors like InsufficientChangesets into NewPayloadError::other(). Since downloaded blocks are fire-and-forget (no CL request/response loop to retry), the silently dropped error means nothing triggers another download attempt and the node sits idle permanently. Now NewPayloadError::Other is propagated as InsertBlockFatalError to trigger a node exit, while NewPayloadError::Eth (validation errors) is logged and treated as non-fatal.
mediocregopher
added
C-bug
Contributor
✅ Changelog found on PR. |
mediocregopher
requested review from
Rjected,
mattsse and
yongkangc
as code owners
yongkangc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, InsertPayloadError::Payload errors were silently dropped in on_downloaded_block, while InsertPayloadError::Block errors were properly handled. This meant fatal errors (e.g. provider errors) wrapped in NewPayloadError::Other would be ignored, leaving the engine tree task alive but unable to execute blocks — causing the node to stall indefinitely instead of exiting.
This can occur when validate_block_with_state fails during EVM environment construction (evm_env_for), which converts provider errors like InsufficientChangesets into NewPayloadError::other(). Since downloaded blocks are fire-and-forget (no CL request/response loop to retry), the silently dropped error means nothing triggers another download attempt and the node sits idle permanently.
Fix
Now NewPayloadError::Other is propagated as InsertBlockFatalError to trigger a node exit, while NewPayloadError::Eth (validation errors) is logged and treated as non-fatal.