fix(rpc): handle simulate precompile self moves#24567
Open
Soubhik-10 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
eth_simulateV1handling formovePrecompileToAddresswhen the source and destination are the same.A self-move should only return
-38022if the source is an existing precompile. If the source is not a precompile, it should returnNotAPrecompilewith-32000, matching the failing Hive case:eth_simulateV1/ethSimulate-move-to-address-itself-reference-38022 (reth_default)Also keeps moved precompiles callable at the destination without adding the destination address to the warm precompile set.