Add base64 encoding where it was missing#96
Open
MatzElectronics wants to merge 2 commits intomasterfrom
Open
Conversation
No need to transmit "No Device", but it is helpful to denote the device that was unable to connect.
Adds flag to let the browser know that it is safe to base64 encode those transmissions
Collaborator
Author
|
To test: Don't connect a device, and open the terminal using the button on the top bar. Then, connect a device |
Collaborator
Author
|
Again, just to reiterate - don't release this fix until solo/200 is fully implemented. |
Contributor
|
Thanks @MatzElectronics - I'll check it out and will wait until Solo/200 is deployed. |
Contributor
|
Addresses an error identified in parallaxinc/solo#200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are safe to implement at any point after solo/200 is fully implemented. There are flags in the browser and a try/catch set up to allow "No port" messages to be received whether they are encoded or not.