Update relative color parsing to latest spec #465
+338
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lative-color-update
…oklch colors"" This reverts commit 81cd955.
devongovett
force-pushed
the
master
branch
3 times, most recently
from
68a1bff to
3930139
Compare
|
@devongovett what would it take to merge this? Tailwind v4 css (for example) ships |
|
So, either we merge it and accept the breaking change as a "fix" since the spec itself had a breaking change, make it opt-in (not great for new projects), or wait for a major version of lightningcss. |
|
I vote for shipping it as a fix. I can't imagine there are many people relying on this behavior. |
|
On the flip side, I don't know that anybody would be bothered by a major version change that didn't actually change anything meaningful? That probably is the safest bet and, IMO, there is no real reason to wait for a major version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS spec was updated in w3c/csswg-drafts#7876 to treat many channel values as only numbers rather than percentages or numbers for the purposes of calculations in relative colors. This is a breaking change since it no longer allows syntax like
calc(l + 10%), you need to docalc(l + 10)orcalc(l * 1.1)depending on what you want to do. In addition, the range of each channel is different, for examplelis 0-100 in lch, but 0-1 in oklch.Unfortunately, we did not ship relative color syntax under a draft flag, so if we release this change in a minor version it might be an unexpected breaking change. Haven't decided what to do here yet.